[Ffmpeg-devel] [ PATCH ] Fix for: Re: ffmpeg does not build on amd64

[Diego Biurrun]

On Wed, Jan 18, 2006 at 10:28:15AM +0000, M?ns Rullg?rd wrote:
> 
> Diego Biurrun said:
> > On Wed, Jan 18, 2006 at 02:58:39AM +0100, Derk-Jan Hartman wrote:
> >> On 18-jan-2006, at 2:07, Diego Biurrun wrote:
> >> >On Tue, Jan 17, 2006 at 04:13:42PM +0000, Dieter wrote:.
> >> >
> >> >>@@ -483,7 +477,7 @@
> >> >>   --disable-audio-oss) audio_oss="no"
> >> >>   ;;
> >> >>   --disable-audio-beos) audio_beos="no"
> >> >>-    extralibs="$extralibs -lbe -lmedia"
> >> >>+    extralibs="$extralibs"
> >> >
> >> >You are modifying BeOS stuff in a FreeBSD patch?
> >>
> >> This is also in VLC media player's patchset. and was reported before
> >> at least once by me.
> >
> > Well, BeOS is Francois' territory...  Then again, adding to the list of
> > extralibs in a --disable option is completely senseless.
> 
> The patch above changes the line to a no-op, which is also silly.

I could say something about the quality of patches I saw in *BSD ports,
but I'll better shut up now...

> > Looking at cvs annotate I notice that this comes from a patch I applied and
> > apparently not reviewed closely enough.
> 
> Shame on you ;-)

Yes :)

Diego