[Ffmpeg-devel] [PATCH] MP4 and MOV encoder support for files > 4GB

Dirk Musfeldt d.musfeldt
Mon Jan 16 13:28:02 CET 2006


Hi,

OK, these are the modified regression tests...



> Hi
> 
> On Fri, Jan 13, 2006 at 10:37:48AM +0100, Dirk Musfeldt wrote:
>> Hi,
>> 
>> this implements the 64 bit chunk offset atom "co64" instead of 32 bit chunk
>> offset atom "stco" if necessary. The size of the of the media data atom
>> "mdat" is also expressed in 64 bit in this case.
>> All uses of url_ftell() are changed to offset_t.
> 
>> -    put_be32(pb, curpos - pos); /* rewrite size */
>> +    put_be32(pb, (unsigned long)(curpos - pos)); /* rewrite size */
> 
> why?
> 

and I removed this cast.


> 
>> +    if (j < UINT32_MAX) {
>> +        url_fseek(pb, mov->mdat_pos, SEEK_SET);
>> +        put_be32(pb, j+8);
> 
> j=UINT32_MAX - 1 -> j+8 > UINT32_MAX
> 
> 
> this also breaks the regression tests, update them or avoid the breakage
> 
> [...]

Regards

Dirk


-------------- next part --------------
A non-text attachment was scrubbed...
Name: movenc.c.diff
Type: application/octet-stream
Size: 14889 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060116/63cf5696/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.regression.ref.diff
Type: application/octet-stream
Size: 1120 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060116/63cf5696/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rotozoom.regression.ref.diff
Type: application/octet-stream
Size: 1119 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060116/63cf5696/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libav.regression.ref.diff
Type: application/octet-stream
Size: 613 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060116/63cf5696/attachment-0003.obj>



More information about the ffmpeg-devel mailing list