[Ffmpeg-devel] [PATCH] nuppelvideo decoder

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

>>  * Copyright (C) 2005 the ffmpeg project
>
> Hmm, I think it is standard practise to add the name of the author here
> instead..

The copyright holder must be a person or a legal entity, something
"the ffmpeg project" is not.

> BTW, what is the official spelling of the name of this project?
>
> FFmpeg or ffmpeg?
>
>> --- Makefile	13 Jan 2006 00:47:16 -0000	1.222
>> +++ Makefile	14 Jan 2006 16:14:44 -0000
>> @@ -171,6 +171,10 @@
>>      OBJS+= cscd.o
>>      OBJS+= lzo.o
>>  endif
>> +ifeq ($(CONFIG_NUV_DECODER),yes)
>> +    OBJS+= nuv.o
>> +    OBJS+= lzo.o
>> +endif
>
> Hmm, CSCD already adds lzo.o to OBJS.  Are multiple entries in OBJS a
> problem?  I expect not, but maybe it would be more elegant to build
> lzo.o if either CSCD or NUV gets built.

We could really do with a more sophisticated build system.  No, I'm
not suggesting autotools.

-- 
M?ns Rullg?rd
mru at inprovide.com