[Ffmpeg-devel] Re: [PATCH] mov fps fix

[Baptiste COUDURIER]

Hi

Michael Niedermayer wrote:
> Hi
> 
> [...]
>
> 1. you must also change/check dts&pts of the returned AVPackets
> 2. use av_set_pts_info()
> 3. use the greatest common divisor of all durations would be more general
> 

All right, i changed the code according to your suggestions. Is it
correct now ?

Btw, is it preferred to keep time_base as 40/1000 for example, or to
reduce it to 1/25 ?

I did not get point 3, did you mean all "stts" samples durations ?

I was wondering if there was any "coding style" guide for ffmpeg. Do you
know if such document exists ?

Thanks a lot for your time.

Here is the attached patch.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mov_fps_fix2.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060110/99a69e6b/attachment.asc>