[Ffmpeg-devel] improved [PATCH] fix DV encoder VLC bit accounting

Dan Maas dmaas
Sun Feb 26 06:52:28 CET 2006

> btw, isnt
> b->prev[a2] = prev;
> enough? (i mean no for(; (b->prev[a2]==k) && (a2<4); a2++)) ?

I'm not 100% sure, but I couldn't convince myself that the for() is
unnecessary, so I left it in for safety... Imagine a block where areas
1, 2, and 3 are already all zero, and area 0 just got zeroed out. If
we adjust b->prev[1] then we must also adjust b->prev[2] and
b->prev[3], otherwise the standard loop iteration pattern won't work:

for (a=0; a<4; a++) {
   prev = b->prev[a];

(since b->mb[prev] might be zero now)

> and next time, please update the regression test checksums too when they
> change through your patch ...

Will do.


More information about the ffmpeg-devel mailing list