[PATCH] rename the "duplicate -loop option" (was Re:[Ffmpeg-devel] Differences between ...)

Michael Niedermayer michaelni
Tue Feb 21 22:53:13 CET 2006


On Tue, Feb 21, 2006 at 12:46:19PM +0100, Luca Abeni wrote:
> Hi Erik,
> On Tue, 2006-02-21 at 12:16 +0100, Erik Slagter wrote:
> [...]
> > I think it's more sane to enable it by default, leaving the user the
> > option to disable it. This means this should actually be possible, I
> > don't know from the top of my head whether -loop requires an argument.
> > IMHO it should. Just like -bframes that complains if it is supplied a
> > value "0" while this could be a very valid value if the default for a
> > certain codec (e.g. h264) is non-zero.
> BTW, I just discovered a funny thing... ffmpeg has two "-loop"
> options :)
> One defined in ffmpeg.c, the other is an AVOption from
> libavcodec/utils.c
> As a result, it is currently impossible to enable the in-loop deblocking
> filter from ffmpeg command line... I did not notice this yesterday
> because I was testing by using my own c test program, and not ffmpeg...
> The attached patch renames the "ffmpeg.c -loop option" so that the
> libavcodec/utils.c one can be used. With this patch, "-loop 1" works.
> To Michael: is the patch ok? Or should I write the patch the other way
> around, by renaming the AVOption's "-loop"?

i dont care which way its solved but one must be renamed of coarse ...
so yea patch ok



More information about the ffmpeg-devel mailing list