[PATCH] rename the "duplicate -loop option" (was Re:[Ffmpeg-devel] Differences between ...)

[Luca Abeni]

Hi Erik,

On Tue, 2006-02-21 at 12:16 +0100, Erik Slagter wrote:
[...]
> I think it's more sane to enable it by default, leaving the user the
> option to disable it. This means this should actually be possible, I
> don't know from the top of my head whether -loop requires an argument.
> IMHO it should. Just like -bframes that complains if it is supplied a
> value "0" while this could be a very valid value if the default for a
> certain codec (e.g. h264) is non-zero.
BTW, I just discovered a funny thing... ffmpeg has two "-loop"
options :)
One defined in ffmpeg.c, the other is an AVOption from
libavcodec/utils.c

As a result, it is currently impossible to enable the in-loop deblocking
filter from ffmpeg command line... I did not notice this yesterday
because I was testing by using my own c test program, and not ffmpeg...

The attached patch renames the "ffmpeg.c -loop option" so that the
libavcodec/utils.c one can be used. With this patch, "-loop 1" works.

To Michael: is the patch ok? Or should I write the patch the other way
around, by renaming the AVOption's "-loop"?

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 DVDNetRent: il primo noleggio on line senza spese di spedizione, per ricevere comodamente a casa i tuoi DVD preferiti!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4631&d=21-2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: loop.diff
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060221/659f578c/attachment.bin>