[Ffmpeg-devel] Re: [PATCH] x264 avc encoding, movenc avcC, ctts

[Michael Niedermayer]

Hi

On Mon, Feb 20, 2006 at 02:14:20PM +0100, Baptiste COUDURIER wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > 
> > just add it for mpeg4 and h264
> > 
> 
> I saw some samples containing MPEG2 having a ctts atom. That would mean
> 3 codecs.
> Why not detecting B frames ? If tried in the modified patch, is this
> acceptable ?

yes


> 
> > [...]
> > 
> > no this is wrong pts-dts does not need to be a multiple of pkt->duration
> > 
> > the correct code IMHO is trk->cluster[cl][id].cts= (pkt->pts - pkt->dts) * enc->time_base.num;
> > though i didnt check the spec ...
> > 
> > also note that mov_write_stts_tag() is totally wrong, it must store the dts
> > not blindly assume they are all equally spaced
> > 
> > [...]
> 
> Here is a modified patch which do not seek and contains last entry.
> About the pkt->duration, did you figure out something ?

use trk->cluster[cl][id].cts= (pkt->pts - pkt->dts) * enc->time_base.num;

[...]

-- 
Michael