[Ffmpeg-devel] [PATCH] grabbing with V4L

Luca Abeni lucabe72
Fri Feb 17 11:40:00 CET 2006

Hi Flavio,

On Wed, 2006-02-15 at 14:34 +0100, Luca Abeni wrote:
> > The patch I've sent didn't create a single new line, it only moves some 
> > image settings initialization to outside the if statement. It was also 
> > not my idea, I borrowed from mplayer ;)
> Yes, looking at the patch I agree that it should not create problems.
> I'll test it tomorrow, just as a confirmation.
I tested your patch, and verified that it does not create any regression.
Uhmm... I still do not understand why it is needed by your webcam driver
but the "regular" bttv driver does not need it...

Anyway, I think your patch is good because it permits to avoid some code
duplication (in fact, after applying your patch all the code around line
212 becomes useless). So, I went ahead and I removed some code that (I
think) is obsoleted by your patch (since desired_palette is already set
by previous code).

Does the attached patch (your patch + some useless code removal) work
for you?

Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 Per i progetti che rimandi da tempo, Findomestic ti offre la soluzione ideale per te, con semplicit? e senza anticipi! Clicca e scopri come
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=3936&d=17-2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: grab-pix-format.diff
Type: text/x-patch
Size: 3899 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060217/468bec83/attachment.bin>

More information about the ffmpeg-devel mailing list