[Ffmpeg-devel] Re: [PATCH] mov parser fixes and enhancements

[Baptiste COUDURIER]

Michael Niedermayer wrote:
> Hi
> 
> On Sat, Feb 11, 2006 at 02:47:47PM +0100, Baptiste COUDURIER wrote:
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Sat, Feb 11, 2006 at 01:28:18AM +0100, Baptiste COUDURIER wrote:
>>>> Hi,
>>>>
>>>> This patch fixes MOV parser to parse correctly stsd atom.
>>>> Especially, parsing this file :
>>>>
>>>> http://www.coudurier.com/showdown2.mov
>>>>
>>>> I tested the patch against all sample I had on hands and I did not
>>>> detect any error, even mp4 and some samples from mplayer archive.
>>>>
>>>> There is one indentation clean, and some big code removal, code which
>>>> isn't needed anymore, mov_read_stsd is(was ?) a big mess.
>>> the whole mov demuxer is a big mess, but patches must be split in
>>> selfcontained parts (1. indention clean, 2. code removial, 3. stsd fix)
>>>
>>> [...]
>>>
>> All right. Here is the stsd fix.
> 
> applied
> 
> [...]
> 

Great, thank you, I will now check and try to clean a bit stsd parser,
or even the whole mov.c, do you have any hints or suggestions ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312