[Ffmpeg-devel] [PATCH] new VOC (de)muxer

[Michael Niedermayer]

Hi

On Thu, Feb 09, 2006 at 01:37:26PM +0100, Aurelien Jacobs wrote:
> On Thu, 9 Feb 2006 02:30:34 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Hi
> > 
> > On Thu, Feb 09, 2006 at 02:17:40AM +0100, Aurelien Jacobs wrote:
> > > On Thu, 9 Feb 2006 02:11:53 +0100
> > > Michael Niedermayer <michaelni at gmx.at> wrote:
> > > 
> > > > Hi
> > > > 
> > > > On Thu, Feb 09, 2006 at 01:36:18AM +0100, Aurelien Jacobs wrote:
> > > > > Hi,
> > > > > 
> > > > > Here is a new (de)muxer for the Creative VOC format.
> > > > > Most features are supported, except silence and repetition (those
> > > > > features don't seem to be wildly used).
> > > > > All codecs are supported except the Creative ADPCM
> > > > > 8 bits to 4, 2.6 or 2 bits. (I will probably add at least one of
> > > > > them later)
> > > > > Just one remark. If you wonder why is voc_read_packet such a
> > > > > wrapper, that's because voc_get_packet will also be used by
> > > > > my AVS demuxer (comming soon ;-).
> > > > 
> > > > [...]
> > > > 
> > > > > @@ -552,6 +552,8 @@
> > > > >  /* aiff.c */
> > > > >  int ff_aiff_init(void);
> > > > >  
> > > > > +#include "voc.h"
> > > > 
> > > > why?
> > > 
> > > To get the declaration of voc_init. The same way as rtp.h just below.
> > > But if you prefer, I will move the declaration of voc_init directly
> > > in avformat.h ?
> > 
> > yes, the other voc specific stuff from voc.h shouldnt be in avformat.h
> 
> Right. Now that I think about it, avformat.h is a "public" header (it
> is installed on the system), so it really can't depend on voc.h.
> Patch updated.

ok, can be applied
and maybe you want to add a regression test for it too ...

[...]
-- 
Michael