[Ffmpeg-devel] [PATCH] Fix for url_fclose() being called on an already closed file
Måns Rullgård
mru
Wed Feb 8 20:17:19 CET 2006
Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> Hi,
> On Wed, Feb 08, 2006 at 03:43:42PM -0000, M?ns Rullg?rd wrote:
>> Colin Ward said:
>> > While looking for a resource leak (which turned out to be in my own
>> > code!) I noticed that in libavformat/utils.c::av_open_input_file() it was
>> > possible for url_fclose() to be called twice in a row due to file_opened
>> > not being set back to 0 after the first call to url_fclose(). The chances
>> > of this are minutely tiny, but please find a patch attached anyway.
>>
>> Could you set the mime type of attached patches to text/x-patch, please? It
>> makes them easier to read.
>
> Well, text/plain would be even prefered by me, if it works for you as
> well...
Sure, text/anything is better than application/binary. The advantage
of text/x-patch is that gnus will display it using diff-mode and
syntax highlighting. That makes the patches easier to read. Gnus
lets me display anything inline, but at work I have to use webmail and
it isn't as flexible.
--
M?ns Rullg?rd
mru at inprovide.com
More information about the ffmpeg-devel
mailing list