[Ffmpeg-devel] [PATCH] Fixes for Darwin/x86

[Dan Villiom Podlaski Christiansen]

On 08/02/2006, at 11.16, Diego Biurrun wrote:

> On Wed, Feb 08, 2006 at 09:09:36AM +0100, Dan Villiom Podlaski  
> Christiansen wrote:
>> On 08/02/2006, at 1.38, Michael Niedermayer wrote:
>>
>>>> While at it, I made a minor change in the way PIC is defined on
>>>> Darwin.
>>>
>>> how is this related to the align stuff? this should be a seperate
>>> patch ...
>>
>> It is related to getting the i386 parts compiling on Darwin/x86. Only
>> the x86-specific code checks whether PIC is defined, so there has
>> been no need to define it until now. This is a necessary fix for
>> getting dynamic builds working on Darwin/x86, although it's not  
>> enough.
>
> But you enable it not only for x86 ...

Yes, I assumed that it should be enabled whenever PIC was used. The  
attach patch fixes it to only be enabled when compiling for Darwin/x86.

Also, the ASMALIGN() macros where moved into a defined(ARCH_X86) ||  
defined(ARCH_X86_64) conditional, to ensure that they weren't defined  
when not needed.

--

- Dan Villiom Podlaski Christiansen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-darwin-i386-fixes.diff
Type: application/applefile
Size: 387 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060208/97b790be/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-darwin-i386-fixes.diff
Type: application/octet-stream
Size: 26450 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060208/97b790be/attachment.obj>
-------------- next part --------------