[Ffmpeg-devel] [PATCH] video4linux2 input

[Erik Slagter]

On Mon, 2006-02-06 at 17:14 +0000, M?ns Rullg?rd wrote:
> >> To be even more elegant, I'd use a enum AND a table. #define's for
> >> constants are evil, indeed.
> >
> > Do you have any good reason to say this or is it just more CS dogma?
> 
> The one good thing with enums is that debugger can show the symbolic names.
> Apart from that, they are semantically equivalent to ints IIRC,

Almost IIRC ;-)

Anyway, that's indeed a shame. C should enforce it's types more
strongly :-( But that's academic.

> with the
> addition of polluting the namespace.  I rarely use them (or debuggers).

Huh? How do you mean a #define does not pollute namespace? I'd rather
say that a define pollutes name space. If you're using _anything_ with
the same name in the same (or included!) file it will cause really
obscure errors!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2771 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060207/a965790c/attachment.bin>