[Ffmpeg-devel] [PATCH] Vorbis I floor type 0 support
Alexander Strasser
eclipse7
Sat Feb 4 10:02:57 CET 2006
Hi,
Oded Shimon wrote:
> On Fri, Jan 27, 2006 at 06:14:35PM +0100, Alexander Strasser wrote:
[...]
> > + vorbis_floor_decode_func floor_decode;
>
> You used a single a variable for pointer to decode function. There's no
> garuntee anywhere in the Vorbis spec that all floors in a single file are
> the same type. You should make this variable in the floor sturct, and per
> mapping/floor.
Yes, i somehow assumed only one type was allowed. Though i yet have to
find a file with mixed floor types. Anyway: fixed.
[...]
Alex (beastd)
More information about the ffmpeg-devel
mailing list