[Ffmpeg-devel] time for a release?
Måns Rullgård
mru
Thu Feb 2 21:11:54 CET 2006
Bryan Mayland <bmayland at leoninedev.com> writes:
> M?ns Rullg?rd wrote:
>> Bryan Mayland <bmayland at leoninedev.com> writes:
>>
>>
>>> That leaves 2 other warnings, one about IPAddressACL not being
>>> uninitialized (which it might be if there are errors in the conf
>>> file, but we're planning to bomb out anyway so what's the point?).
>>>
>>
>> In non-time-critical situations, I usually initialize such variables
>> to some invalid value, even if the variable can never actually be used
>> uninitialized, to silence the compiler warnings.
>>
> Well this certainly isn't time-critical, it is only when loading
> the config file. I've included it in the attached.
>>
>>> The other is about get_longterm_datarate being unused, which has
>>> been true for over a year now. I'm not sure what the original
>>> intent of this function was (maybe had something to do with
>>> pre-preroll code?).
>>>
>>
>> Submit a patch to remove it.
>>
> Consider it done!
Applied.
--
M?ns Rullg?rd
mru at inprovide.com
More information about the ffmpeg-devel
mailing list