[Ffmpeg-devel] Compiler warnings

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Wed, Feb 01, 2006 at 09:03:36AM +0000, Dieter wrote:
>> >> It is good practice to keep harmless warnings away.  That way, the
>> >> real ones are more easily noticed.
>> 
>> YES!
>> 
>> > The easy way to silence the rest of the warnings is to supply
>> > the -Wno-pointer-sign option to gcc
>> 
>> Can you guarantee that every possible pointer-sign warning
>> now and in the future will be harmless?  
>
> no, can you gurantee that every odd numbered line will be bug free? so 

Sure, make them blank.

> why not print a warning for them? its not about that it might in some
> very rare cases indicate a bug but if it does more often then the
> remaning lines (i can show you cases where warining free lines where
> buggy, can you show me one where a f([(signed)]p) case was buggy)
> and MOST important are you checking the code to see if its buggy before
> you add (signed)/(unsigned) casts or are you maybe just blindly 
> suppressing the warnings without understanding the code
> now tell me how THAT is better from suppressing the warnings with a
> compiler switch ...

I can think of cases where a signed/unsigned difference could cause
unexpected behavior, but these are rare.

-- 
M?ns Rullg?rd
mru at inprovide.com