[Ffmpeg-devel] [PATCH] video4linux2 input

Luca Abeni lucabe72
Wed Feb 1 10:59:51 CET 2006


On Tue, 2006-01-31 at 19:33 +0100, Michael Niedermayer wrote:
> > So, I think I have 2 options:
> > 1) leave "av_set_pts_info(st, 48, 1, 1000000);" as it is (and eventually
> > provide a patch switching audio.c, grab.c & friends to 64bit pts later)
> > or
> > 2) change it to "av_set_pts_info(st, 64, 1, 1000000);" and change
> > audio.c, grab.c and grab_bktr.c to 64bit pts in the v4l2.diff patch that
> > has to be applied when committing v4l2.c
> > 
> > Let me know which option you prefer, and I'll send the updated files.
> i prefer neither, they are both equal, the only bad thing would be leaving
> them at 48 in the end :)
Ok; I attach a new version of the v4l2.c file, that:
- uses PixelFormat when needed
- uses 64 bit pts
- uses a const int for desired_video_buffers (instead of a #define)

The new v4l2.diff patch attached also changes audio.c & friends to use
64 bit pts, to be consistent with v4l2.c.

I hope this version can be committed to the CVS; if anyone still sees
problems let me know and I'll do my best to address them.


P.S.: if someone commits this code to the CVS, please also commit the
raw.diff patch I sent on Monday (Michael already said it looks ok)
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 Sfida la fortuna con Suzi Wan, in palio fantastici premi ogni giorno!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4721&d=1-2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4l2-3.diff
Type: text/x-patch
Size: 6536 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060201/6137cbcd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4l2.c
Type: text/x-csrc
Size: 13213 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060201/6137cbcd/attachment.c>

More information about the ffmpeg-devel mailing list