[Ffmpeg-devel] Re: [PATCH] file length handling

[Ronald S. Bultje]

Hi Michael,

On Mon, 2006-12-18, Michael Niedermayer wrote:
> On Mon, Dec 18, 2006 at 08:55:43PM +0100, Ronald S. Bultje wrote:
> > On Mon, 18 Dec 2006, Michael Niedermayer wrote:
> > > On Mon, Dec 18, 2006 at 09:20:49AM -0500, Ronald S. Bultje wrote:
> > > > -#define LIBAVFORMAT_VERSION_INT ((51<<16)+(6<<8)+0)
> > > > -#define LIBAVFORMAT_VERSION     51.6.0
> > > > +#define LIBAVFORMAT_VERSION_INT ((52<<16)+(0<<8)+0)
> > > > +#define LIBAVFORMAT_VERSION     52.0.0
> > > >  #define LIBAVFORMAT_BUILD       LIBAVFORMAT_VERSION_INT
[..]
> external or not how does adding a field to the end break anyting?
> no external code should depend on any struct size if it does its
> broken IMHO

I don't add it to the end. URLContext has a char filename[1] at the end,
which is used for dynamic sizing of the struct.

[.. confusion about 0 and -1 for file_size ..]
> ok, but please document that with a doxygen comment for file_size

Added (kind of extensive, hope it's not too long). New patch attached
(also removes the cosmetic change in the previous patch).

Cheers,
Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: urictx-len.patch
Type: text/x-patch
Size: 6776 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061218/b84c978c/attachment.bin>