[Ffmpeg-devel] [PATCH] FLV decoder metadata reading

Guillaume POIRIER poirierg
Tue Dec 12 11:37:22 CET 2006


On 12/12/06, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hi,
> On 12/12/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Hi
> >
> > On Mon, Dec 11, 2006 at 03:39:06PM -0800, Allan Hsu wrote:
> [..]
> > > All fixed/changed in the attached version of the patch.
> >
> > patch looks ok
> Patch compiles and seem to work alright, but regression tests are
> broken (unrelated to this patch, they were broken before):


Ok, regtests do pass on x86, and this patch doesn't break them.

However, this patch has trailing whitespaces, which I refuse to fix
(possibly tabs too, but I didn't check). Please resend a clean patch.

An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)

More information about the ffmpeg-devel mailing list