[Ffmpeg-devel] [PATCH] flv muxer metadata

[Michael Niedermayer]

Hi

On Fri, Dec 08, 2006 at 08:20:48PM -0800, Allan Hsu wrote:
> >>From the secret journal of Aurelien Jacobs:
> 
> > For an example of how you could implement lookup table grep for
> > voc_codec_tags and it's use with codec_get_tag().
> >
> 
> Here is a revised version of the patch that uses codec_get_tag().

> 
> 	-Allan
> -- 
> Allan Hsu <allan at counterpop dot net>
> 1E64 E20F 34D9 CBA7 1300 1457 AC37 CBBB 0E92 C779

> Index: libavformat/flvenc.c
> ===================================================================
> --- libavformat/flvenc.c	(revision 7260)
> +++ libavformat/flvenc.c	(working copy)
> @@ -20,10 +20,27 @@
>   */
>  #include "avformat.h"
>  #include "flv.h"
> +#include "riff.h"
>  
>  #undef NDEBUG
>  #include <assert.h>
>  
> +const CodecTag flv_video_codec_ids[] = {
> +    {CODEC_ID_FLV1,    FLV_CODECID_H263  },
> +    {CODEC_ID_FLASHSV, FLV_CODECID_SCREEN},
> +    {CODEC_ID_VP6F,    FLV_CODECID_VP6   },
> +    {CODEC_ID_NONE,    0}
> +};
> +
> +const CodecTag flv_audio_codec_ids[] = {

these 2 should either be static or have a ff_ prefix

except that iam fine with the patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes