[Ffmpeg-devel] [RFC][PATCH] wma with sse on windows fix

[Ramiro Polla]

Reimar Doeffinger wrote:
> Hello,
> On Mon, Dec 11, 2006 at 10:11:03AM +0100, Benjamin Larsson wrote:
>   
>> Benjamin Larsson skrev:
>>     
>>> I didn't test/compile this patch, can someone with windows verify if
>>> this fixes the crashes ?
>>>       
>>  
>> I got some reports that this actually do fix the crashes. So I will 
>> commit this in a few days if it works ok under Linux.
>>     
>
> Probably not important but did someone do a performance test? I
> specifically moved things to stack variables for rtjpeg decoding since
> 1) It IMHO makes the code more readable.
> 2) does not need dereferencing another pointer to get the address.
>
>   
Using a 14mb wma input file:

ffmpeg-nopatch.exe -benchmark -y -i wma.wma wma.wav
average of 3.875s

ffmpeg-patch.exe -benchmark -y -i wma.wma wma.wav
average of 3.907s

It never crashed, before and after the patch.

AMD Athlon 64 2800+, running Windows XP SP2 (32-bit, I gave up on 
Windows x64).

Ramiro Polla