[Ffmpeg-devel] [PATCH] idct8 in Altivec for H.264 decoding

Guillaume POIRIER poirierg
Sat Dec 2 15:51:23 CET 2006


On 12/1/06, Luca Barbato <lu_zero at gentoo.org> wrote:
> Guillaume POIRIER wrote:
> > last call before I apply it.
> check this one
> > Note that it may break with gcc3.x: ffmpeg can't compile currently
> now should build w/out problems
> > with gcc 3.3 on PPC, so I don't know if this routine compiles with it
> > or not. Probably not.
> Changes:
> - avoiding C++ style variable declaration
> - vec_sra needs unsigned values for the shift amount
> - the h264_idct8_add prototype doesn't have int16 dct[8][8] but DCTELEM
> *block as second parameter.
> Reproducing h264 videos seems to be ok, the regression test looks broken
> for me even w/out patches...

They do pass here.
Patch applied,
Thanks for testing and fixing.

An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)

More information about the ffmpeg-devel mailing list