[Ffmpeg-devel] [BUG] Vorbis artifacts

[Diego Biurrun]

On Thu, Aug 31, 2006 at 01:05:47PM +0200, Diego Biurrun wrote:
> On Thu, Aug 31, 2006 at 12:56:42PM +0200, Baptiste Coudurier wrote:
> > Luca Barbato wrote:
> > > Baptiste Coudurier wrote:
> > >>
> > >> Luca Barbato wrote:
> > >>> [...]
> > >>>      /* samples output by the codec. we reserve more space for avsync
> > >>>         compensation */
> > >>> -    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2];
> > >>> +    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2]  __attribute__((aligned(16)));
> > >>>      unsigned int audio_buf_size; /* in bytes */
> > >>>      int audio_buf_index; /* in bytes */
> > >>>      AVPacket audio_pkt;
> > >> Quick question, should we use DECLARE_ALIGNED(16) here or not ? Why not ?
> > >>
> > > 
> > > __attribute__((aligned(16))) seems to be supported by sunstudio, icc and
> > > xlc, not just gcc.
> > > 
> > > I hadn't checked metrowerks and ms offering seems supporting it too (at
> > > least from the icc manual I assume so.
> > > 
> > 
> > I see. I just wonder why was the macro ever invented ?
> 
> The macro is for assembler, not C code.

Nonsense, I keep confusing it with ASMALIGN ...

Diego