[Ffmpeg-devel] [BUG] Vorbis artifacts

[Michael Niedermayer]

Hi

On Thu, Aug 31, 2006 at 02:46:11PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> >Hi
> >
> >On Thu, Aug 31, 2006 at 12:35:54PM +0200, Baptiste Coudurier wrote:
> >  
> >>Hi
> >>
> >>Luca Barbato wrote:
> >>    
> >>>[...]
> >>>     /* samples output by the codec. we reserve more space for avsync
> >>>        compensation */
> >>>-    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2];
> >>>+    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2]  
> >>>__attribute__((aligned(16)));
> >>>     unsigned int audio_buf_size; /* in bytes */
> >>>     int audio_buf_index; /* in bytes */
> >>>     AVPacket audio_pkt;
> >>>      
> >>Quick question, should we use DECLARE_ALIGNED(16) here or not ? 
> >>    
> >
> >yes it should be used
> >
> >[...]
> >  
> Should it be used everywhere ? I've seen lots of other places where it 
> is used.

yes, ideally it should be used everywhere, attribute() should never be
used directly as our code should be ISO C not GNU C ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is