[Ffmpeg-devel] [BUG] Vorbis artifacts

[Luca Barbato]

Luca Barbato wrote:
> Diego Biurrun wrote:
> 
>> It appears to be PPC-specific, I cannot reproduce it on x86, neither can
>> others.  I'll investigate further and try to find the revision that
>> broke it.
> 
> I got an interesting segfault related to the float_to_int16_altivec.
> 
> I'll try to bisect a bit.

simple workaround:

align the dst buffer like this, don't ask me why the unaligned
float_to_int16 is causing those issues because I don't know and I had it
checked by others just in case I was missing something obvious and my
system was lucky enough to hide some bugs.


Index: ffplay.c
===================================================================
--- ffplay.c    (revision 6002)
+++ ffplay.c    (working copy)
@@ -133,7 +133,7 @@
     int audio_hw_buf_size;
     /* samples output by the codec. we reserve more space for avsync
        compensation */
-    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2];
+    uint8_t audio_buf[(AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2]
__attribute__((aligned(16)));
     unsigned int audio_buf_size; /* in bytes */
     int audio_buf_index; /* in bytes */
     AVPacket audio_pkt;

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero