[Ffmpeg-devel] [PATCH] Attempt image2 in watermark vhook

[Guillaume POIRIER]

Hi,

On 8/30/06, Guillaume Poirier <gpoirier at mplayerhq.hu> wrote:
> Hi,
>
> Luca Abeni wrote:
> > Hi,
> >
> > On Wed, 2006-08-30 at 15:34 +0200, Guillaume POIRIER wrote:
> > [...]
> >
> >>>Try this:
> >>>./ffmpeg -i \
> >>>/home/guillaume/Desktop/guillaume/The_Godfather-1972_snow.avi \
> >>>-vhook '/home/guillaume/Prgm/ffmpeg/vhook/watermark.so -f
> >>>/home/guillaume/Documents/7.15.gif ' \
> >>>outfile.avi
> >>>
> >>>You must enclose the whole vhook (DLL and parameters) in single
> >>> quotes (and keep it in one single line), and probably substitute the ~ by
> >>>the real path (~ is really
> >>>interpreted by your shell).
> >>
> >>Ok, it works well without your patch, but with your patch, here's what happens:
> >>
> >>./ffmpeg -i /home/guillaume/Desktop/guillaume/The_Godfather-1972_x264.avi
> >>-vhook '/home/guillaume/Prgm/ffmpeg/vhook/watermark.so -f
> >>/home/guillaume/Documents/7.15.gif' outfile.avi
> >>FFmpeg version SVN-r6128, Copyright (c) 2000-2004 Fabrice Bellard
> >>  configuration:  --enable-gpl --enable-swscaler
> >>  libavutil version: 49.0.0
> >>  libavcodec version: 51.11.0
> >>  libavformat version: 50.5.0
> >>  built on Aug 30 2006 15:23:25, gcc: 4.0.3 (Ubuntu 4.0.3-1ubuntu5)
> >>Input #0, avi, from
> >>'/home/guillaume/Desktop/guillaume/The_Godfather-1972_x264.avi':
> >>  Duration: 00:00:20.0, start: 0.000000, bitrate: 1184 kb/s
> >>  Stream #0.0: Video: h264, yuv420p, 688x576, 25.00 fps(r)
> >>/home/guillaume/Prgm/ffmpeg/vhook/watermark.so: undefined symbol: img_convert
> >>Failed to add video hook function:
> >>/home/guillaume/Prgm/ffmpeg/vhook/watermark.so -f
> >>/home/guillaume/Documents/7.15.gif
> >
> > I think the problem here is that you configured ffmpeg with
> > --enable-swscaler, but watermark.so has not been ported to swscale yet
> > (when --enable-swscaler is used, img_convert() is not compiled into
> > libavcodec, so the hook cannot link it)
>
> Oh, I thought that that patch was meant to add support for
> libswscaler, which isn't the case now that I have a look at it.
>
> I'll re-configure and re-test when I get the time.

Ok, it works as expected. Applied

Guillaume

-- 
A thing is not necessarily true because a man dies for it.
-- Oscar Wilde