[Ffmpeg-devel] [PATCH] Wildcard and catalog image sequences

[Michel Bardiaux]

Michael Niedermayer wrote:
> Hi
> 
> On Wed, Aug 30, 2006 at 12:38:30PM +0200, Michael Niedermayer wrote:
> [...]
>>>>> +static void free_catalog(int last_index, char*** pindex_vector)
>>>>> +{
>>>>> +    int i;
>>>>> +    char** index_vector = *pindex_vector;
>>>>> +    for(i=0;index_vector&&i<=last_index;i++)
>>>>> +        av_free(index_vector[i]);
>>>>> +    av_free(index_vector);
>>>>> +    *pindex_vector = NULL;
>>>> av_freep()
>>>> and the index_vector variable seems unneeded
>>> Wilco, but my code was actually correct. It seems to me you *require* 
>>> compact code and are ready to reject a patch simply because you find the 
>>> coding style too verbose for your taste!
>> yes, code must be simple, patches must be minimal, no superfluous changes
> 
> the coding rules also say that:
> "Main priority in FFmpeg is simplicity and small code size (=less bugs). "
> this has been written by fabrice IIRC and was there since a very long time
> 
> [...]

I would dispute that a 4-liner instead of a 1-liner using ?: generates 
more object code; and it does not seem *simpler* to me. I think you tend 
too much towards compactness even at the price of obfuscation. But, OK, 
I'll try to respect your wishes.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/