[Ffmpeg-devel] [PATCH] Wildcard and catalog image sequences

[Michael Niedermayer]

Hi

On Wed, Aug 30, 2006 at 12:38:30PM +0200, Michael Niedermayer wrote:
[...]
> > >>+static void free_catalog(int last_index, char*** pindex_vector)
> > >>+{
> > >>+    int i;
> > >>+    char** index_vector = *pindex_vector;
> > >>+    for(i=0;index_vector&&i<=last_index;i++)
> > >>+        av_free(index_vector[i]);
> > >>+    av_free(index_vector);
> > >>+    *pindex_vector = NULL;
> > >
> > >av_freep()
> > >and the index_vector variable seems unneeded
> > 
> > Wilco, but my code was actually correct. It seems to me you *require* 
> > compact code and are ready to reject a patch simply because you find the 
> > coding style too verbose for your taste!
> 
> yes, code must be simple, patches must be minimal, no superfluous changes

the coding rules also say that:
"Main priority in FFmpeg is simplicity and small code size (=less bugs). "
this has been written by fabrice IIRC and was there since a very long time

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is