[Ffmpeg-devel] [PATCH] Attempt image2 in watermark vhook

[Víctor Paesa]

Hi,

> V?ctor Paesa a ?crit :
>> Hi,
>>
>>> Guillaume POIRIER skrev:
>>>> Hi,
>>>>
>>>> On 8/18/06, V?ctor Paesa wrote:
>>>>> After five days with no negative comments probably next step would be
>>>>> to
>>>>> commit the patch, probably by the person listed in MAINTAINERS for
>>>>> vhook/watermark.c :-)
>>>> Could you please provide a sample commandline to test the behaviour of
>>>> FFmpeg with and without your code?
>>>>
>>>> I'm not familiar with the watermak features of FFmpeg, so I'm not sure
>>>> how to test your patch before committing it (even though it's very
>>>> small, I just can't shovel every patch without some kind of testing,
>>>> be it just a compilation test on a different machine that the one of
>>>> the original dev)
>>>>
>>>> Guillaume
>>> ffmpeg -i infile -vhook '/path/to/watermark.so -f image.png' outfile
>>>
>>> It should fail watermarking with png without the patch.
>>> When patch is applied it should work.
>>>
>>
>> Correct, and, for the sake of completeness, GIF should not be broken
>> by patch so
>>
>> ffmpeg -i infile -vhook '/path/to/watermark.so -f image.gif' outfile
>>
>> should produce same results with and without patch.
>
> Ok, i've tried with this commandline:
>
> ./ffmpeg -i
> /home/guillaume/Desktop/guillaume/The_Godfather-1972_snow.avi -vhook
> /home/guillaume/Prgm/ffmpeg/vhook/watermark.so -f ~/Documents/7.15.gif
> outfile.avi
> FFmpeg version SVN-r6123, Copyright (c) 2000-2004 Fabrice Bellard
>    configuration:  --enable-gpl
>    libavutil version: 49.0.0
>    libavcodec version: 51.11.0
>    libavformat version: 50.5.0
>    built on Aug 29 2006 13:49:28, gcc: 4.0.3 (Ubuntu 4.0.3-1ubuntu5)
> Input #0, avi, from
> '/home/guillaume/Desktop/guillaume/The_Godfather-1972_snow.avi':
>    Duration: 00:00:20.0, start: 0.000000, bitrate: 1202 kb/s
>    Stream #0.0: Video: snow, yuv420p, 688x576, 25.00 fps(r)
> Watermark: There is no filename specified.
>
>
> I guess I'm missing smth. I don't use the commanline tool "ffmpeg" so
> I'm  not familiar with its commandline. Maybe it doesn't work because I
> missed smth.

Try this:
./ffmpeg -i \
/home/guillaume/Desktop/guillaume/The_Godfather-1972_snow.avi \
-vhook '/home/guillaume/Prgm/ffmpeg/vhook/watermark.so -f
/home/guillaume/Documents/7.15.gif ' \
outfile.avi

You must enclose the whole vhook (DLL and parameters) in single
 quotes (and keep it in one single line), and probably substitute the ~ by
the real path (~ is really
interpreted by your shell).

Merci,
V?ctor