[Ffmpeg-devel] [PATCH] AVISynth support

Guillaume POIRIER gpoirier
Fri Aug 25 18:23:20 CEST 2006


Hi,

Diego Biurrun a ?crit :
> On Fri, Aug 25, 2006 at 04:35:05PM +0200, Steve Lhomme wrote:


> I guesstimate that there are 10-20 approved but unapplied FFmpeg patches
> in my mailbox alone, most of them waiting far longer than a week.


BTW, I try to apply as many OKed patches as possible, but I wanna make 
sure they build and pass regression test on my machine and possibly 
others. I also try to test that what the patch is supposed to do is 
actually done. Even if this is a brain dead job, it takes time, and 
needs to be done to avoid breaking the SVN every now and then.
That doesn't prevent the patches I applied to break the SVN as I haven't 
tried every possible combination of option (who can?) but I hope it 
allows to find the most obvious ones.
At Linux TAG, Andrew Morton said that he was still amazed how many 
patches just don't even compile, which, you must agree, is the basic 
thing you expect from a patch.

Anyway Steve, I want to personally thank you for contributing back your 
patches to the community, after all, you have a long history of 
submitted patches.
Maybe you just don't split your patches in small enough parts? I noticed 
that the smallest the patch, the most likely it is to get it merged.
Yes, it takes time to split, but so is sending back and forth big patches.

Take the SIMD optimizations for Snow: Snow is Michael's baby, so you'd 
expect him to jump and apply them... well things did not go like that. 
Robert (who wrote the optimizations) had to split his patch in 4-5 
pieces to get them applied.

So, as Diego said, you are not being singled out.

Guillaume




More information about the ffmpeg-devel mailing list