[Ffmpeg-devel] CDXA in libavformat [patch]

[Allan Sandfeld Jensen]

On Saturday 19 August 2006 00:30, Michael Niedermayer wrote:
> Hi
>
> On Fri, Aug 18, 2006 at 06:33:28PM +0200, Allan Sandfeld Jensen wrote:
> > Hi again
> >
> > I've tried implementing the information in a CDXA format wrapper and it
> > seems to work perfectly.
> >
> > Technically you don't need the code in cdxa_read_header, but I thought it
> > would be best to skip forward rather than let the MPEG packet decoder
> > search through 64kbyte of zeroes.
>
> disagree, if the code isnt needed its redundant and shouldnt be there
>
Well, it is a once a file optimization so the decoder doesn't have to search 
64kbytes of zeroes for the first MPEG packet.

> [...]
>
> > +static int cdxa_probe(AVProbeData *p)
> > +{
> > +    /* check file header */
> > +    if (p->buf_size <= 32)
> > +        return 0;
> > +    if (p->buf[0] == 'R' && p->buf[1] == 'I' &&
> > +        p->buf[2] == 'F' && p->buf[3] == 'F' &&
> > +        p->buf[8] == 'C' && p->buf[9] == 'D' &&
> > +        p->buf[10] == 'X' && p->buf[11] == 'A')
> > +        return AVPROBE_SCORE_MAX;
> > +    else
> > +        return 0;
> > +}
>
> that could be put in mpegps_probe()
>
Okay

`Allan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpeg.patch
Type: text/x-diff
Size: 948 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060824/3fbffb91/attachment.patch>