[Ffmpeg-devel] [PATCH] fix mpegaudiodec on ARM and benchmark

[Michael Niedermayer]

Hi

On Thu, Aug 24, 2006 at 01:48:25AM +0200, Aurelien Jacobs wrote:
[...]
> Then with A32_BITSTREAM_READER I had two more errors which are fixed by
> the attached patch.

for cook.c iam ok, what does the maintainer say? if cook needs the ALT reader
then it should be explained in a comment in cook.c why

for dv.c i disagree, dv.c should #define ALT_BITSTREAM_READER and undef the
others before the #includes


> 
> Now the benchmarks:
> 
> #define ALT_BITSTREAM_READER
> BENCHMARKs: VC:   0.000s VO:   0.000s A:  78.751s Sys:   0.419s =   79.171s
> BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.4702% Sys:  0.5298% = 100.0000%
> 
> #define LIBMPEG2_BITSTREAM_READER
> BENCHMARKs: VC:   0.000s VO:   0.000s A:  78.978s Sys:   0.422s =   79.399s
> BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.4691% Sys:  0.5309% = 100.0000%
> 
> #define A32_BITSTREAM_READER
> BENCHMARKs: VC:   0.000s VO:   0.000s A:  70.622s Sys:   0.357s =   70.978s
> BENCHMARK%: VC:  0.0000% VO:  0.0000% A: 99.4973% Sys:  0.5027% = 100.0000%
> 
> We are getting even closer to libmad :-)
> 
> What about something like the second attached patch ?

no objection if and only if the regression tests pass as well as with ALT_*

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is