[Ffmpeg-devel] ADI Blackfin port and optimization

[Michael Niedermayer]

Hi

On Wed, Aug 23, 2006 at 11:01:31AM -0400, Michael Benjamin wrote:
> On 8/23/06, Diego Biurrun <diego at biurrun.de> wrote:
> 
> >It's OK.  What will be the fate of the rest of the patch?  If it will
> >not get applied I see little sense in adding this to configure.
> 
> 
> Attached is a patch for dsputil (it assumes configure patch applied).

> diff -pruN ffmpeg/libavcodec/bfin/dsputil_bfin.c ffmpeg-bfin/libavcodec/bfin/dsputil_bfin.c
[...]
> +void dsputil_init_bfin( DSPContext* c, AVCodecContext *avctx );

this should be in the header file or dsputil.c from where its called,
here its useless


> +
> +int sad8x8_bfin( void *c, uint8_t *blk1, uint8_t *blk2, int line_size, int h )

this should be static int sad8x8_bfin( ...

except these iam fine with the patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is