[Ffmpeg-devel] ADI Blackfin port and optimization

[Michael Benjamin]

On 8/22/06, Diego Biurrun <diego at biurrun.de> wrote:On Tue, Aug 22, 2006 at
06:30:05PM -0400, Michael Benjamin wrote:
>
> --- ffmpeg/libavcodec/bfin/dsputil
>
> _bfin.c     1969-12-31 19:00:00.000000000 -0500
> > +++ ffmpeg-bfin/libavcodec/bfin/dsputil_bfin.c        2006-08-22 17:53:
> 38.000000000 -0400
> > @@ -0,0 +1,55 @@
> > +
> > +#include "../avcodec.h"
> > +#include "../dsputil.h"
>
> You can leave out the ../, same below.


But the libavcodec/Makefile has no -I.
      1 #
      2 # libavcodec Makefile
      3 # (c) 2000-2005 Fabrice Bellard
      4 #
      5 include ../config.mak
      6
      7 # NOTE: -I.. is needed to include config.h
      8 CFLAGS=-DHAVE_AV_CONFIG_H -I.. -I$(SRC_PATH)/libavutil $(OPTFLAGS) \
      9        -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE
$(AMR_CFLAGS)

grep -e 'dsputil\.h' -e 'avcodec\.h' libavcodec/*/dsputil_*.c
libavcodec/alpha/dsputil_alpha.c:#include "../dsputil.h"
libavcodec/armv4l/dsputil_arm.c:#include "../dsputil.h"
libavcodec/armv4l/dsputil_iwmmxt.c:#include "../dsputil.h"
libavcodec/i386/dsputil_mmx.c:#include "../dsputil.h"
libavcodec/mlib/dsputil_mlib.c:#include "../dsputil.h"
libavcodec/ppc/dsputil_altivec.c:#include "../dsputil.h"
libavcodec/ppc/dsputil_ppc.c:#include "../dsputil.h"
libavcodec/ps2/dsputil_mmi.c:#include "../dsputil.h"
libavcodec/sh4/dsputil_align.c:#include "../avcodec.h"
libavcodec/sh4/dsputil_align.c:#include "../dsputil.h"
libavcodec/sh4/dsputil_sh4.c:#include "../avcodec.h"
libavcodec/sh4/dsputil_sh4.c:#include "../dsputil.h"
libavcodec/sparc/dsputil_vis.c:#include "../dsputil.h"

I have a dsputil patch w/ "../dsputil.h" and "../avcodec.h" -- is that OK?