[Ffmpeg-devel] [PATCH] MJPEG wrongly displayed with vertical YUV422

[Michael Niedermayer]

Hi

On Sun, Aug 20, 2006 at 07:23:49PM +0200, Eric Piel wrote:
> 05/08/2006 00:26 PM, Michael Niedermayer wrote/a ?crit:
> >Hi
> >
> >On Fri, Aug 04, 2006 at 06:15:24PM +0200, Eric Piel wrote:
> >[...]
> >>>PIX_FMT_YUVJ422VP is unaceptable, it should be called PIX_FMT_YUVJ440P
> >>Here is attached a corrected patch which fix the naming. Sorry, I had 
> >>tried to find the real naming but without success... those names are 
> >>quite a mess for me.
> >>
> >>
> >>>and such vertical subsampled format can pretty much only occur
> >>>if you rotate 4:2:2 video, should we really support that? what about
> >>>rotated interlaced video?
> >>Well, every tool which support JPEG seems to support this format, so why 
> >>not ffmpeg? IMHO, even if it is not so much used, the simple fact that 
> >>it allows to display lossless rotated video is worthy. Adding support 
> >>for it in ffmpeg is rather simple (especially since the patch is just 
> >>there ;-) ).
> >>
> >>Please apply,
> >>Eric
> >>
> >
> >>Index: libavutil/avutil.h
> >>===================================================================
> >>--- libavutil/avutil.h	(r??vision 5924)
> >>+++ libavutil/avutil.h	(copie de travail)
> >>@@ -53,6 +53,7 @@
> >>     PIX_FMT_RGB24,     ///< Packed pixel, 3 bytes per pixel, RGBRGB...
> >>     PIX_FMT_BGR24,     ///< Packed pixel, 3 bytes per pixel, BGRBGR...
> >>     PIX_FMT_YUV422P,   ///< Planar YUV 4:2:2 (1 Cr & Cb sample per 2x1 Y 
> >>     samples)
> >>+    PIX_FMT_YUV440P,   ///< Planar YUV 4:4:0 (1 Cr & Cb sample per 1x2 Y 
> >>samples)
> >>     PIX_FMT_YUV444P,   ///< Planar YUV 4:4:4 (1 Cr & Cb sample per 1x1 Y 
> >>     samples)
> >
> >adding things into the middle of enums is not allowed, as it breaks binary
> >compatibility
> >
> Ok, sorry I thought this file was only internal :-( So here is a new 
> version of the patch which add the definition at the end.

but before PIX_FMT_NB (= pix format number)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is