[Ffmpeg-devel] [PATCH] Attempt image2 in watermark vhook

[Víctor Paesa]

Hi,

> Guillaume POIRIER skrev:
>> Hi,
>>
>> On 8/18/06, V?ctor Paesa wrote:
>>>
>>> After five days with no negative comments probably next step would be
>>> to
>>> commit the patch, probably by the person listed in MAINTAINERS for
>>> vhook/watermark.c :-)
>>
>> Could you please provide a sample commandline to test the behaviour of
>> FFmpeg with and without your code?
>>
>> I'm not familiar with the watermak features of FFmpeg, so I'm not sure
>> how to test your patch before committing it (even though it's very
>> small, I just can't shovel every patch without some kind of testing,
>> be it just a compilation test on a different machine that the one of
>> the original dev)
>>
>> Guillaume
> ffmpeg -i infile -vhook '/path/to/watermark.so -f image.png' outfile
>
> It should fail watermarking with png without the patch.
> When patch is applied it should work.
>

Correct, and, for the sake of completeness, GIF should not be broken
by patch so

ffmpeg -i infile -vhook '/path/to/watermark.so -f image.gif' outfile

should produce same results with and without patch.

Thanks,
V?ctor Paesa