[Ffmpeg-devel] [PATCH] enable libswscale

[Víctor Paesa]

Hi,

> On Wed, 2006-08-16 at 00:56 +0200, Diego Biurrun wrote:
> > On Tue, Aug 15, 2006 at 01:13:33AM +0200, V?ctor Paesa wrote:
> > >
> > > Under Cygwin, if I configure with --disable-static --enable-shared
> > > --enable-swscaler, then the build fails because of I have undefined
> > > references (forbidden in Win32 shared libraries):
> > >
> > > /home/Inma/src/FFmpeg-20060813-5994/ffmpeg/libswscale/swscale.c:2313:
> > > undefined reference to `_av_log'
> >
> > Huh?  You made libswscale work?  It's not yet compiling..
> It should compile (and work - I tested both static and shared swscale on
> linux/x86) if you copy img_format.h from mplayer/libmpcodec to
> libswscale[*].
Right, with the copy of img_format.h it statically compiled right away
in Cygwin, shared libraries took just adding the missing avutil.

> On Wed, Aug 16, 2006 at 10:03:29AM +0200, Luca Abeni wrote:
>>
>> On Wed, 2006-08-16 at 00:56 +0200, Diego Biurrun wrote:
>> > On Tue, Aug 15, 2006 at 01:13:33AM +0200, V?ctor Paesa wrote:
>> > >
>> > > --- ffmpeg-old/libswscale/Makefile      2006-08-11
>> 20:15:30.000000000 +0200
>> > > +++ ffmpeg/libswscale/Makefile  2006-08-15 00:37:06.546875000 +0200
>> > > @@ -5,6 +5,7 @@
>> > >  ifeq ($(BUILD_SHARED),yes)
>> > >  LIBVERSION=$(SWSVERSION)
>> > >  LIBMAJOR=$(SWSMAJOR)
>> > > +EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF)
>> > >  endif
>> >
>> > This is bad, you're throwing away the contents of EXTRALIBS.
>> Yes, I think it should be
>> EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF) $(EXTRALIBS)
>> (as in the libavcodec's Makefile; I do not know why I missed it).
>> If you agree, I'll commit this change this evening.
>
> I agree.
>
Thanks!

Regards,
V?ctor Paesa