[Ffmpeg-devel] [PATCH] fix compilation when Snow ENcoder is disabled

[Guillaume POIRIER]

Hi,

On 8/13/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Sun, Aug 13, 2006 at 07:21:55PM +0200, Guillaume POIRIER wrote:
> [...]
> > >#ifdef CONFIG_ENCODER
> > > void h263_encode_init(MpegEncContext *s);
> > >#else
> > > static void h263_encode_init(MpegEncContext *s) {assert(0);}
>     ^^^^^^
>
> > >#endif
> >
> >
> > The problem is that you end up having multiple definitions of the same
> > function. This can be "solved" by using the "static" keyword, as in the
> > attached patch.
> > With this patch, GCC3.3 and 4.2 are happy when encoders are disabled.
> >
> > What do you think about it?
>
> well as its what i suggested iam fine with it

Sorry, it's just that I have failed to see the "static" keyword in one
of the solutions you proposed.
I should get more sleep and really read the mails instead of skimming
through them.

Anyway, patch applied (along with Diego's suggestion), thanks.

Guillaume
-- 
A thing is not necessarily true because a man dies for it.
-- Oscar Wilde