[Ffmpeg-devel] [PATCH] '/nop' illegal for old versions of GAS

[Michael Niedermayer]

Hi

On Wed, Aug 09, 2006 at 04:12:16AM +1000, John Dalgliesh wrote:
> 
> Hi,
> 
> Sorry to butt in, but this has been going on too long now...
> 
> On Mon, 7 Aug 2006, Michael Niedermayer wrote:
> >
> >Hi
> >
> >On Mon, Aug 07, 2006 at 10:33:31AM +1000, Nigel Pearson wrote:
> >>	I assumed you wanted to keep the ability
> >>to pass in an opcode to do rounding?
> >
> >yes, of course, the code must still work ...
> 
> OK I think that there is a misunderstanding here. The only value ever 
> passed into those IDCT macros is '/nop'. That is, the rounder argument is 
> never used for anything except generating an assembler comment.

look again


[blah blah]

> Tested on linux x86 and compiles fine, does not cause any regressions to 
> fail. (Two regressions fail for esoteric formats with svn head for me; the 
> patch does not change this.)

of course it works on linux ...


[...]
> If I am wrong about it being a misunderstanding - either there is some 
> weird use of the macros/arguments that I missed - or it is desirable to 
> retain the rounder argument for posterity, then I will happily produce a 
> patch meeting those criteria.

[...]
> @@ -458,11 +456,11 @@
>  DC_COND_ROW_IDCT(  96(%0),104(%0),112(%0),120(%0), 96(%1),paddd (%2), 11)

look, its not a nop

[...]
> @@ -705,7 +703,7 @@
>  Z_COND_IDCT(  96(%0),104(%0),112(%0),120(%0), 96(%1),paddd (%2), 11, 1f)

and another

[...]
> @@ -795,7 +791,7 @@
>  Z_COND_IDCT(  96(%0),104(%0),112(%0),120(%0), 96(%1),paddd (%2), 11, 5f)

and yet another

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is