[Ffmpeg-devel] [PATCH] fix snow x86 SIMD

[Luca Barbato]

Michael Niedermayer wrote:

> sorry, no, every patch you submit gets dirtier then the previous, either
> cleanly change the code or leave it
> REG_b IS ebx, and alot of code will break if you change this, every use of
> ebp, "b", "m", REG_BP, REGb, ... at least, and not only that but its 
> conceptually wrong,  its like "#define PI sqrt(2)"

ok

> 
> additionally, id suggest that you run the regression tests before sumitting
> patches, (i think ill ignore every asm related PIC fix if the author doesnt
> explicitly say that the regression tests passed)

I'm just a mere proxy since I don't have access to x86 for now (as in my
x86 would die for overheat in few min...)

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero