[Ffmpeg-devel] [PATCH] enable libswscale

[Luca Abeni]

Hi Diego,

On Mon, 2006-08-07 at 17:14 +0200, Diego Biurrun wrote:
[...]
> > > Careful, svn:externals only works for directories, not files.
> > Ok... So, we will probably need to have a copy of those two files in the
> > repository for some time :(
> 
> Why not put them in libavutil (which is mandatory for MPlayer) then?
Well, they will stay in the repository only for a limited time, until a
proper solution will be implemented.
asmalign.h maybe can be put in libavutil, but I think img_format.h
should not go in libavutil (it has nothing to do with ffmpeg).

> > --- Makefile	(revision 5944)
> > +++ Makefile	(working copy)
> > @@ -11,6 +11,10 @@
> >  
> > +ifeq ($(CONFIG_SWSCALER),yes)
> > +CFLAGS := -I$(SRC_PATH)/libswscale $(CFLAGS)
> > +endif
> 
> Why not simply += here?
Since I removed the "#include_next", "-I$(SRC_PATH)/libswscale" must go
before all the other "-I". += would put it after them.
An alternative could be
ifeq ($(CONFIG_SWSCALER),yes)
CFLAGS=-I$(SRC_PATH)/libswscale
endif

CFLAGS+=$(OPTFLAGS) -I. -I$(SRC_PATH) -I$(SRC_PATH)/libavutil \
       -I$(SRC_PATH)/libavcodec -I$(SRC_PATH)/libavformat \
       -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE

but I did not like it. Anyway, I can change it if needed.


			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !