[Ffmpeg-devel] Re: [PATCH] seeking in GXF

[Reimar D?ffinger]

Hello,
On Mon, Jul 31, 2006 at 06:40:03PM +0200, Baptiste Coudurier wrote:
> > I think this is already marked in line 482 of the current code, the
> > "NOTE:...". But if you can _hear_ glitches this means that the last packet
> > has been filled up with some (almost) random crap, right? If the ffmpeg
> > muxer creates such files, it might be a good idea to "fix" there as well.
> 
> Well, if by fixing you mean memset to 0. I sure can do that. But it is
> not required by the specs.

you do this:
> put_buffer(pb, pkt->data, GXF_AUDIO_PACKET_SIZE);

regardless of pkt->size, which results in two questions:
1) can this sometimes crash
2) might this leak information from the user's system

concerning 2) I think it is an important criteria that the muxers do not
store any data beyond what the media contains, not like that funny .doc
format that contains traces of past revisions...

Greetings,
Reimar D?ffinger