[Ffmpeg-devel] [PATCH] Basic H.264 encoder

[Michael Niedermayer]

Hi

On Fri, Apr 21, 2006 at 03:33:01PM +0200, Panagiotis Issaris wrote:
[...]
> > On Wed, Apr 12, 2006 at 04:01:49PM +0200, Panagiotis Issaris wrote:
> > [...]
> > > ?- motion vectors are set to zero
> >
> > that is a reason to reject it unless you convice me that it will be fixed
> > soon
> We are currently trying to get the motion vectors working. Unfortunately,
> we are having some problems with figuring out how to use the motion 
> compensation API (or even if there exists any). It seems only the Snow codec
> is using the motion compensation code, without being integrated in the
> mpegvideo.c file. All the other codecs seem to be intertwined with mpegvideo.c
> code.
> 
> So, here are some questions we are struggling with:
> - Is it better to modify mpegvideo.c for using motion compensation for our 
> H.264 codec, or can we do it without touching that file? (To us, it seems the
> latter is cleaner.)

i think i agree, but there are many things in mpegvideo.c which will be
needed in h.264 too so we will at some point have to factor these parts out of
mpegvideo.c so they can be used by both


> - Will integrating in mpegvideo.c make it easier to get rate control working?

probably no


> - In the sourcecode there's a remark that insinuates that the motion control 
> code will be separated from the MpegEncContext struct. Is that planned for 
> the near future?

no (unless you do it)


[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is