[Ffmpeg-devel] [PATCH] snow mmx + sse2 part 5

Michael Niedermayer michaelni
Mon Apr 17 17:36:05 CEST 2006


Hi

On Mon, Apr 17, 2006 at 04:04:58PM +0200, Guillaume POIRIER wrote:
> Hi,
> 
> On 16 Apr 2006 22:05:48 -0000, Wolfram Gloger
> <wmglo at dent.med.uni-muenchen.de> wrote:
> > [ff_snow_inner_add_yblock_mmx appears to be miscompiled with gcc-2.95.x]
> >
> > Here is a fix for this issue.  The operand in question is loaded into
> > a register explicitly by the asm, so there is no possible performance
> > loss I can see.
> 
> You're right. Please run the regression tests on you machine to make
> sure they pass, and I'll do the same, meanwhile, I hope Michael can
> have a look at it and tell us what he thinks about your patch.

well, ive not seen the misscompiled code (no gdb disassembly was posted)
so i cant comment, but if this fixes the issue iam not against it


[...]
-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is





More information about the ffmpeg-devel mailing list