[Ffmpeg-devel] [PATCH] Memory leaks...

Mat heavensdoor78
Tue Sep 27 15:56:15 CEST 2005


> Just for the record: I'm not an FFmpeg developer (in case you got that 
> impression), 

Oki.

> so I'm probably not competent to comment on this. However, the fix you 
> propose looks wrong to me because code_table gets assigned to the 
> global variable huff_code_table[i]. So we don't want to free this 
> memory because it's going to get used well beyond the lifetime of that 
> loop.

You are right, I didn't watch carefully the code before, I did a fast 
test in 10 minutes.
huff_code_table is global... so I suppose  av_mallocz  for  code_table  
should be  av_mallocz_static too...

In this way I don't get memory leaks in  apiexample.c





More information about the ffmpeg-devel mailing list