[Ffmpeg-devel] [PATCH] fix for PSP encoding

[Michael Niedermayer]

Hi

On Tue, Sep 20, 2005 at 12:38:56AM +0200, oandrieu at gmail.com wrote:
Content-Description: message body and .signature
>  Michael Niedermayer [Monday 19 September 2005] :
>  >
>  > Hi
>  > 
>  > On Fri, Sep 16, 2005 at 02:33:17AM +0200, oandrieu at gmail.com wrote:
>  > > Hi,
>  > > 
>  > > The psp format in ffmpeg apparently broke with the latest firmware of
>  > > the PSP (2.0). Here's a patch. 
>  > > 
>  > > It's basically the same patch that was posted on the list a
>  > > couple of months ago. Some parts were not committed because of
>  > > issues with the widechar conversion function used to encode the
>  > > title of the stream: here I just handle the case where the title
>  > > is in ASCII (any character with a high bit is replaced by a
>  > > '?'). It's a bit crude, but heh.
>  > > 
>  > > -- 
>  > >    Olivier
>  > 
>  > [...]
>  > > -#define MODE_PSP 3 // example working PSP command line: 
>  > > -// ffmpeg -i testinput.avi  -f psp -r 14.985 -s 320x240 -b 768 -ar 24000 -ab 32 M4V00001.MP4
>  > > +#define MODE_PSP 3
>  > 
>  > is the example no longer correct?
> 
> Oh it is, it's just that it's not the best place for an
> example. Anyway I left it.

[...]

> -#define MODE_PSP 3 // example working PSP command line: 
> +#define MODE_PSP 3
> +// example working PSP command line: 
[...]
> -    put_tag(pb, "APRF");   /* audio */
> +    put_tag(pb, "APRF");  /* audio */
[...]
> -    put_be32(pb, 0x34 );  /* size */
> +    put_be32(pb, 0x34 );   /* size */

cosmetics

[...]

-- 
Michael