[Ffmpeg-devel] [PATCH] dvbsub.c typos

Wolfram Gloger wmglo
Thu Sep 8 23:57:34 CEST 2005


Hi,

I discovered the following typos:

--- ffmpeg/libavcodec/dvbsub.c	Mon Jul 18 10:52:34 2005
+++ ffmpeg-wg/libavcodec/dvbsub.c	Thu Sep  8 23:33:44 2005
@@ -343,10 +343,10 @@
         for (object_id = 0; object_id < h->num_rects; object_id++) {
             /* Object Data segment */
 
-            if (h->rects[region_id].nb_colors <= 4) {
+            if (h->rects[object_id].nb_colors <= 4) {
                 /* 2 bpp, some decoders do not support it correctly */
                 bpp_index = 0;
-            } else if (h->rects[region_id].nb_colors <= 16) {
+            } else if (h->rects[object_id].nb_colors <= 16) {
                 /* 4 bpp, standard encoding */
                 bpp_index = 1;
             } else {

... while debugging a teletext decoder, which generates graphical
subtitles from teletext pages.  It more or less works, but the only
way I can watch these generated graphical subtitles is when muxing to
a transport stream and then with ffplay, correct?

Is there such a thing as a graphical DVD subtitle, i.e. could there be
a dvdsubenc.c (encoder)?  If yes, is anyone working on that?

Regards,
Wolfram.





More information about the ffmpeg-devel mailing list