[Ffmpeg-devel] [PATCH] Add DESTDIR support to Makefiles

[İsmail Dönmez]

On Tuesday 18 October 2005 22:44, Diego Biurrun wrote:
> On Tue, Oct 18, 2005 at 08:55:36PM +0300, ?smail D?nmez wrote:
> > On Tuesday 18 October 2005 20:48, M?ns Rullg?rd wrote:
> > > Diego Biurrun <diego at biurrun.de> writes:
> > > > On Tue, Oct 18, 2005 at 08:18:20PM +0300, ?smail D?nmez wrote:
> > > >> On Tuesday 18 October 2005 14:12, Diego Biurrun wrote:
> > > >> > On Tue, Oct 18, 2005 at 12:55:56PM +0200, Diego Biurrun wrote:
> > > >> > > On Tue, Oct 18, 2005 at 11:31:22AM +0300, ?smail D?nmez wrote:
> > > >> > > > So can we please apply this patch or tell me if there is
> > > >> > > > anything wrong with it with respect to whitespace or
> > > >> > > > something?
> > > >> > >
> > > >> > > Samuel Hocevar achieves the same effect with the following (much
> > > >> > > simpler) patch in his Debian packages.
> > > >> > >
> > > >> > > Sam, what do you say?  I'm tempted to apply your patch.
> > > >> >
> > > >> > ... and here is the patch ...
> > > >>
> > > >> Nope that doesn't look correct to me. It looks like just doing
> > > >> --prefix=$DESTDKR which is not the point of the patch.
> > > >
> > > > WTF?  Have you read the patch?
> > >
> > > As long as prefix et al are not used in the makefiles for anything
> > > besides installing files, Sam's patch should be OK.  If these
> > > variables are used in any other way (e.g. in -D compiler flags),
> > > things could break.  In our case, I believe it's safe.
> >
> > Yup but it might break later on, if these variables are getting used
> > inside the code which doesn't seem to be the case for *now* ;)
>
> I must admit I find both your arguments quite esoteric.  Tangible
> examples anyone?

like -DCONFDIR=/etc/ffmpeg.conf in Makefiles and code using CONFDIR variable 
then it will depend on conf_prefix and Sam's patch will break it. But this is 
all "may be". Lets do things the right way pls? :)

Regards,
ismail