[Ffmpeg-devel] Re: [PATCH] RTP/RTSP and MPEG4-AAC audio (Repost)

[Michael Niedermayer]

Hi

On Monday 23 May 2005 16:02, Romain DEGEZ wrote:
> Michael Niedermayer wrote:
[...]
> > the whole extra_infos system is unaceptable its significantly too
> > complicated and messy
> > the string id from an attribute is looked up in the attr_names table
> > converted to a integer send into rtp_set_int/str_attribute() which then
> > practically converts the integer into the point in a codec specific
> > structure (void *extra_infos) where the int or char* argument is stored
> > (not surprisingly you forget to free a few things which got allocated on
> > the way)
> > just store the values in a single codec independant structure
>
> I changed the way to store the values. Do you prefer this way ?

yes, but its still more complicated then needed, more precisely 
SDP_FMTP_ENTRY__* is unneeded, attr_names could contain the offsets of the 
rtp_payload_data_t structure fields where each entry should be stored

[...]


-- 
Michael